You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is my default browser after installing Git on windows. Detecting it instead of falling back to cmd.exe improves Roo Code's ability to figure out which commands to run initially.
Type of change
Bug fix (non-breaking change which fixes an issue)
New feature
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
How Has This Been Tested?
Checklist:
My code follows the patterns of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
Additional context
Related Issues
Reviewers
Important
Add detection for Git Bash on Windows in shell detection logic and update tests accordingly.
Behavior:
Detects Git Bash on Windows in getWindowsShellFromVSCode() in shell.ts.
Returns /usr/bin/bash if profile source is "Git Bash" or name includes "git bash".
Tests:
Adds tests in shell.test.ts for Git Bash detection based on profile source and name.
Ensures fallback to cmd.exe if no special profile is matched.
Misc:
Updates getShellFromEnv() in shell.ts to prioritize SHELL over COMSPEC on Windows.
This description was created by for 88f6f91. It will automatically update as commits are pushed.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Sorry to miss this! Is this still something we want to merge?
Roo wasn't able to figure out my terminal type initially on Windows (it recovered after running a command). I stopped using Git Bash on windows though, and I haven't seen anyone complain about this issue, so fine to close out for now.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dosubot
bot
added
the
size:L
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
github-project-automation
bot
moved this from PR [Pre Approval Review]
to Done
in Roo Code Roadmap
Description
This is my default browser after installing Git on windows. Detecting it instead of falling back to cmd.exe improves Roo Code's ability to figure out which commands to run initially.
Type of change
How Has This Been Tested?
Checklist:
Additional context
Related Issues
Reviewers
Important
Add detection for Git Bash on Windows in shell detection logic and update tests accordingly.
getWindowsShellFromVSCode()inshell.ts./usr/bin/bashif profile source is "Git Bash" or name includes "git bash".shell.test.tsfor Git Bash detection based on profile source and name.cmd.exeif no special profile is matched.getShellFromEnv()inshell.tsto prioritizeSHELLoverCOMSPECon Windows.This description was created by
for 88f6f91. It will automatically update as commits are pushed.